Fixed issue where text alignment was expected for enum#899
Merged
jadams-tresys merged 1 commit intoapache:mainfrom Dec 22, 2022
Merged
Fixed issue where text alignment was expected for enum#899jadams-tresys merged 1 commit intoapache:mainfrom
jadams-tresys merged 1 commit intoapache:mainfrom
Conversation
This small change checks against the repElement (the dfdx:repType) instead of the represented element in the enumeration (typically a string). In the past we would typically expect the alignment to line up with whatever encoding was used for strings, but when using 1-bit alignment, daffodil wouuld complain about the strings being unaligned even though they are internally represented by something other than a string that is 1-bit aligned. Now we check to see what kind of representation (text or binary) the repElement is and check alignment based on that. DAFFODIL-2596
Contributor
Author
|
There may be other areas where repElement should be used in this code, but this definitely fixes the alignment issues that Mike B was seeing. |
stevedlawrence
approved these changes
Dec 22, 2022
Member
stevedlawrence
left a comment
stevedlawrence
left a comment
There was a problem hiding this comment.
+1, but we really need to come up with a design where this kind of bug isn't possible. It wouldn't surprise me if there are other places where this kind of change is needed. And even if we track them all down, it's going to be too easy for new changes to not do this right.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small change checks against the repElement (the dfdx:repType) instead of the represented element in the enumeration (typically a string).
In the past we would typically expect the alignment to line up with whatever encoding was used for strings, but when using 1-bit alignment, daffodil wouuld complain about the strings being unaligned even though they are internally represented by something other than a string that is 1-bit aligned.
Now we check to see what kind of representation (text or binary) the repElement is and check alignment based on that.
DAFFODIL-2596