Implement 'P' textNumberPattern feature.#911
Merged
mbeckerle merged 1 commit intoapache:mainfrom Jan 13, 2023
Merged
Conversation
mbeckerle
commented
Jan 12, 2023
.../src/main/scala/org/apache/daffodil/processors/parsers/ConvertTextStandardNumberParser.scala
Outdated
Show resolved
Hide resolved
stevedlawrence
approved these changes
Jan 12, 2023
Member
stevedlawrence
left a comment
stevedlawrence
left a comment
There was a problem hiding this comment.
+1 👍 just some minor comments/questions
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesTextNumber.scala
Outdated
Show resolved
Hide resolved
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesTextNumber.scala
Outdated
Show resolved
Hide resolved
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesTextNumber.scala
Outdated
Show resolved
Hide resolved
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesTextNumber.scala
Outdated
Show resolved
Hide resolved
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesTextNumber.scala
Show resolved
Hide resolved
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesTextNumber.scala
Outdated
Show resolved
Hide resolved
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesTextNumber.scala
Show resolved
Hide resolved
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesTextNumber.scala
Show resolved
Hide resolved
.../src/main/scala/org/apache/daffodil/processors/parsers/ConvertTextStandardNumberParser.scala
Outdated
Show resolved
Hide resolved
tuxji
approved these changes
Jan 12, 2023
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesTextNumber.scala
Outdated
Show resolved
Hide resolved
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesTextNumber.scala
Outdated
Show resolved
Hide resolved
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesTextNumber.scala
Show resolved
Hide resolved
.../src/main/scala/org/apache/daffodil/processors/parsers/ConvertTextStandardNumberParser.scala
Show resolved
Hide resolved
mbeckerle
commented
Jan 12, 2023
Contributor
Author
mbeckerle
left a comment
mbeckerle
left a comment
There was a problem hiding this comment.
All current issues should be fixed now.
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesTextNumber.scala
Outdated
Show resolved
Hide resolved
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesTextNumber.scala
Show resolved
Hide resolved
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesTextNumber.scala
Outdated
Show resolved
Hide resolved
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesTextNumber.scala
Show resolved
Hide resolved
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesTextNumber.scala
Outdated
Show resolved
Hide resolved
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesTextNumber.scala
Show resolved
Hide resolved
The 'P' is also a COBOL feature from their picture clauses. Also this change set incorporates additional review feedback on the 'V' feature change set. Note that the 'P' and 'V' feature does not support some obscure textNumberPattern as yet such as: 1. a textNumberPattern with a trailing 'V' (no 0 digits after) 2. combining 'V' with an exponent specification. Those usages are allowed technically by the DFDL v1.0 specification (the grammar in section 13.6.1.1 labeled Figure 4), but that usage is so obscure that I am NOT going to create a bug report about implementing these behaviors until someone complains. Similarly it is technically possible to use say, CR (carriage return) or ASCII NUL as your plus sign character. I claim that is a mistake in the DFDL spec to allow that, so use of line-ending characters is not allowed. DAFFODIL-2763
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'P' is also a COBOL feature from their picture clauses.
Also this change set incorporates additional review feedback on the 'V' feature change set.
Note that the 'P' and 'V' feature does not support some obscure textNumberPattern as yet such as:
a textNumberPattern with a trailing 'V' (no 0 digits after)
combining 'V' with an exponent specification.
Those usages are allowed technically by the DFDL v1.0 specification (the grammar in section 13.6.1.1 labeled Figure 4), but that usage is so obscure that I am NOT going to create a bug report about implementing these behaviors until someone complains.
Similarly it is technically possible to use say, CR (carriage return) or ASCII NUL as your plus sign
character. I claim that is a mistake in the DFDL spec to allow that, so use of line-ending characters is not allowed.
DAFFODIL-2763