Merged
Conversation
tuxji
approved these changes
Jan 23, 2023
| Root: tnp26 | ||
| Purpose: This test demonstrates that textStandardDecimalSeparator can be a whitespace-separated list of | ||
| single characters that appear (individually) in the data as the decimal separator | ||
| --> |
Contributor
There was a problem hiding this comment.
Even though this comment and the next one were outdated, why were they deleted instead of updated?
Contributor
Author
There was a problem hiding this comment.
I believe these block comments, which just restate what is obvious from the test itself, serve no purpose.
I will change the test names however, to better reflect the specific thing they are testing.
Activated tests, made them expect an error. This was issuing "Not Yet Implemented". DAFFODIL-847
mbeckerle
force-pushed
the
daf-847-sde
branch
from
b9d78b8 to
57aba60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Activated tests, made them expect an error.
DAFFODIL-847