minor: add test to cover IPC arrow file read#1450
Merged
milenkovicm merged 2 commits intoapache:mainfrom Feb 11, 2026
Merged
Conversation
Contributor
Author
|
@danielhumanmod, @mattcuento, @killzoner review would be appreciated if you have time |
milenkovicm
force-pushed
the
minor_add_test_for_arrow_read
branch
from
93b9915 to
f5be95e
Compare
mattcuento
reviewed
Feb 11, 2026
| #[case::standalone(standalone_context())] | ||
| #[case::remote(remote_context())] | ||
| #[tokio::test] | ||
| async fn should_execute_sql_app_name_show( |
Contributor
There was a problem hiding this comment.
what's the reasoning on removing this one? Wondering since the table registered is in parquet
Contributor
There was a problem hiding this comment.
Nvm I see the sql is the exact same as should_execute_sql_collect. Was this case intended to assert on the job name/test session properties?
Contributor
Author
There was a problem hiding this comment.
there is another test which test app name i believe
killzoner
reviewed
Feb 11, 2026
Co-authored-by: jgrim <killzoner@users.noreply.github.com>
milenkovicm
changed the title
Contributor
Author
|
thanks guys for reviews |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
looks like arrow read is not supported, opened apache/datafusion#20280 to add proto support for it.
What changes are included in this PR?
Are there any user-facing changes?