feat: Add a version method to the configuration information of CometConf #3702
Closed
guixiaowen wants to merge 1 commit intoapache:mainfrom
Closed
feat: Add a version method to the configuration information of CometConf #3702guixiaowen wants to merge 1 commit intoapache:mainfrom
guixiaowen wants to merge 1 commit intoapache:mainfrom
Conversation
Member
|
@guixiaowen Thanks for your work—adding version to the configuration is a great suggestion. However, the versions of configurations involved in this change are now difficult to track, and setting them all uniformly to 0.14.0 may not be accurate. Additionally, we already have documentation for different versions. |
Author
@wForget Thank you very much for your reply. I will close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3700
Rationale for this change
Add a version method to the configuration information of CometConf.
Eg:
COMET_IO_ADJUST_READRANGE_SKEW
after this pr:
val COMET_IO_ADJUST_READRANGE_SKEW: ConfigEntry[Boolean] =
conf("spark.comet.parquet.read.io.adjust.readRange.skew")
.category(CATEGORY_PARQUET)
.version("0.14.0")
.doc("In the parallel reader, if the read ranges submitted are skewed in sizes, this " +
"option will cause the reader to break up larger read ranges into smaller ranges to " +
"reduce the skew. This will result in a slightly larger number of connections opened to " +
"the file system but may give improved performance.")
.booleanConf
.createWithDefault(false)
What changes are included in this PR?
Improve the configuration information description
How are these changes tested?
UT