Skip to content

feat: Add a version method to the configuration information of CometConf #3702

Closed
guixiaowen wants to merge 1 commit intoapache:mainfrom
guixiaowen:comet-3700
Closed

feat: Add a version method to the configuration information of CometConf #3702
guixiaowen wants to merge 1 commit intoapache:mainfrom
guixiaowen:comet-3700

Conversation

@guixiaowen
Copy link

Which issue does this PR close?

Closes #3700

Rationale for this change

Add a version method to the configuration information of CometConf.

Eg:
COMET_IO_ADJUST_READRANGE_SKEW

after this pr:

val COMET_IO_ADJUST_READRANGE_SKEW: ConfigEntry[Boolean] =
conf("spark.comet.parquet.read.io.adjust.readRange.skew")
.category(CATEGORY_PARQUET)
.version("0.14.0")
.doc("In the parallel reader, if the read ranges submitted are skewed in sizes, this " +
"option will cause the reader to break up larger read ranges into smaller ranges to " +
"reduce the skew. This will result in a slightly larger number of connections opened to " +
"the file system but may give improved performance.")
.booleanConf
.createWithDefault(false)

What changes are included in this PR?

Improve the configuration information description

How are these changes tested?

UT

@guixiaowen guixiaowen changed the title Add a version method to the configuration information of CometConf #3700 feat:Add a version method to the configuration information of CometConf #3700 Mar 16, 2026
@guixiaowen guixiaowen changed the title feat:Add a version method to the configuration information of CometConf #3700 feat: Add a version method to the configuration information of CometConf #3700 Mar 16, 2026
@guixiaowen guixiaowen changed the title feat: Add a version method to the configuration information of CometConf #3700 feat: Add a version method to the configuration information of CometConf Mar 16, 2026
@wForget
Copy link
Member

wForget commented Mar 17, 2026

@guixiaowen Thanks for your work—adding version to the configuration is a great suggestion. However, the versions of configurations involved in this change are now difficult to track, and setting them all uniformly to 0.14.0 may not be accurate. Additionally, we already have documentation for different versions.

@guixiaowen
Copy link
Author

@guixiaowen Thanks for your work—adding version to the configuration is a great suggestion. However, the versions of configurations involved in this change are now difficult to track, and setting them all uniformly to 0.14.0 may not be accurate. Additionally, we already have documentation for different versions.

@wForget Thank you very much for your reply. I will close this.

@guixiaowen guixiaowen closed this Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add a version method to the configuration information of CometConf

2 participants