feat: Support Spark expression: current_time_zone#4348
Merged
comphead merged 1 commit intoMay 15, 2026
Merged
Conversation
comphead
approved these changes
May 15, 2026
Contributor
Author
|
Thanks @comphead for the review and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3133
Rationale for this change
Spark's CurrentTimeZone expression is declared
Unevaluable. It walks the plan, finds every CurrentTimeZone, readsSQLConf.get.sessionLocalTimeZoneat plan time, and substitutes a Literal(, StringType) in place of the expression, so Comet would only see a Literal(String).We just need test and verify.
What changes are included in this PR?
Add
current_timezone.sqlHow are these changes tested?
run sql test in spark3.4/3.5/4.0 and prettier check