feat: implement parse_url#4350
Draft
parthchandra wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4150.
Rationale for this change
parse_url is a commonly used Spark SQL function that currently falls back to the JVM. Adding native support lets Comet accelerate queries that use it. The native implementation in DataFusion already exists (datafusion-spark crate); this PR wires the Spark expression through the Comet serde layer to the native
UDFs.
Because the native implementation has known divergences from Spark on certain edge cases (percent-encoding in QUERY values, FILE part for path-less URLs — tracked in apache/datafusion#21943), the expression is marked Incompatible and gated behind
spark.comet.expression.ParseUrl.allowIncompatible=true.
Note: #4152 implemented parse_url but was closed in favor of #4231 which did not implement parse_url
What changes are included in this PR?
are reported correctly.
How are these changes tested?
Three new SQL test files covering different configurations:
All tests pass on both Spark 4.0 and Spark 4.1 profiles.