Allow plain Python literals in regexp function wrappers#1493
Open
renato2099 wants to merge 4 commits intoapache:mainfrom
Open
Allow plain Python literals in regexp function wrappers#1493renato2099 wants to merge 4 commits intoapache:mainfrom
renato2099 wants to merge 4 commits intoapache:mainfrom
Conversation
Making ruff happy
ntjohnson1
reviewed
Apr 13, 2026
timsaucer
reviewed
Apr 14, 2026
Member
timsaucer
left a comment
timsaucer
left a comment
There was a problem hiding this comment.
This is a nice addition. I think we should update the docstrings to not have lit() since we can take these values directly now.
| string: Expr, pattern: Expr, start: Expr | None = None, flags: Expr | None = None | ||
| string: Expr, | ||
| pattern: Expr | str, | ||
| start: Expr | str | None = None, |
Member
There was a problem hiding this comment.
I think start should be Expr | int | None not str
Comment on lines
+1598
to
+1599
| start: Expr | str | None = None, | ||
| n: Expr | str | None = None, |
Member
There was a problem hiding this comment.
I think we want these as int not str
| start: Expr | str | None = None, | ||
| n: Expr | str | None = None, | ||
| flags: Expr | str | None = None, | ||
| sub_expr: Expr | str | None = None, |
Member
There was a problem hiding this comment.
I think the capture group (sub_expr) is also an int. We should verify
Member
|
Also worth noting is I've been working on a skill that will do these in a more automated way: #1484 It might be worth comparing what you came up with vs the agent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1446.
Rationale for this change
Make regex functions more pythonic
What changes are included in this PR?
Changes to regex functions such that we can improve their usability by making them more pythonic
Are there any user-facing changes?
Regex functions are more pythonic now