Fix Already Borrowed Panic When SessionContext Used in Multiple Threads #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d" Panic in multi-thread.
Member
|
I'll go ahead and close this since it has been open for a year and is in draft. @kylebrooks-8451 feel free to re-open if you resume work on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #366
Rationale for this change
If you use
SessionContextfrom multiple threads you can get a "Already Borrowed" panic from Pyo3PyCell.What changes are included in this PR?
Removed unneeded &mut self references to pyclasses.
Are there any user-facing changes?
Yes, I made the RecordBatchStream an actual python iterator.