add support for insert into ... select ... returning ...#1132
Merged
alamb merged 1 commit intoapache:mainfrom Feb 12, 2024
Merged
add support for insert into ... select ... returning ...#1132alamb merged 1 commit intoapache:mainfrom
insert into ... select ... returning ...#1132alamb merged 1 commit intoapache:mainfrom
Conversation
"insert into test select 1 returning 2" now parses correctly "select 1 as returning" which is valid in MySQL and used to parse without error still parses without error (and is now tested) "select 1 returning", which is a syntax error in postgres, sqlite and MariaDB, but is valid in MySQL, and SQL Server, used to parse without error, and now returns a syntax error.
Pull Request Test Coverage Report for Build 7875414967Details
💛 - Coveralls |
lovasoa
changed the title
insert into ... select ... returning ...
alamb
approved these changes
Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
insert into test select 1 returning 2now parses correctlyselect 1 as returningwhich is valid only in MySQL and SQL Server and used to parse without error still parses without error (and is now tested)select 1 returning, which is a syntax error in postgres, sqlite and MariaDB, but is valid in MySQL and SQL Server, used to parse without error, and now returns a syntax error.The
insert into ... select ... returning ...syntax is quite useful in SQLPage