Add parse_keyword_with_tokens for paring keyword and tokens combination#1141
Merged
alamb merged 2 commits intoapache:mainfrom Feb 29, 2024
Merged
Add parse_keyword_with_tokens for paring keyword and tokens combination#1141alamb merged 2 commits intoapache:mainfrom
parse_keyword_with_tokens for paring keyword and tokens combination#1141alamb merged 2 commits intoapache:mainfrom
Conversation
jmhain
reviewed
Feb 25, 2024
| match self.peek_token().token { | ||
| Token::Word(w) if expected == w.keyword => { | ||
| for (idx, token) in tokens.iter().enumerate() { | ||
| if self.peek_nth_token(idx + 1).token != *token { |
Contributor
There was a problem hiding this comment.
This is probably a non-issue since tokens should always be small, but it seems worth noting that this is unnecessarily quadratic over the length of tokens due to the loop in peek_nth_token.
Member
Author
There was a problem hiding this comment.
Thanks. Added a note for that.
9 tasks
Pull Request Test Coverage Report for Build 8056633029Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple follow up to #1134 to add a function
parse_keyword_with_tokensto deal with the case that the parser expects keyword + token combination, instead of a mix of multiple peek_token, expect_keyword, expect_token calls.