ISSUE-1147: Add support for MATERIALIZED CTEs#1148
Conversation
In Postgres, the [NOT] MATERIALIZED keywords can be applied when creating CTEs. Add support for them.
Pull Request Test Coverage Report for Build 8095954676Details
💛 - Coveralls |
| #[cfg_attr(feature = "visitor", derive(Visit, VisitMut))] | ||
| pub enum CteAsMaterialized { | ||
| /// The WITH statement does not specify MATERIALIZED behavior | ||
| Default, |
There was a problem hiding this comment.
Most other places in sqlparser-rs use Option<..> to represent the case when a clause is not present.
Since I had this branch checked out locally to resolve a merge conflict, I went ahead and made that change as well in 6df536a
There was a problem hiding this comment.
Ah for sure!
This route means we should remove the Default enum member though because now it's not useful, and if it does get added at some point it'll print with extra whitespace.
Mind if I add a commit to the PR doing so?
There was a problem hiding this comment.
Sure -- go ahead. I think I did remove CteAsMaterialized::Default in 6df536a though
There was a problem hiding this comment.
Ah nevermind, so you did. I misread it. Thanks!
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @ReppCodes -- looks good to me
3 participants
In Postgres, the [NOT] MATERIALIZED keywords can be applied when creating CTEs. Add support for them.