Skip to content

BigQuery support inline comment with hash syntax#1192

Merged
alamb merged 1 commit intoapache:mainfrom
validio-io:bq-hash-comment
Apr 7, 2024
Merged

BigQuery support inline comment with hash syntax#1192
alamb merged 1 commit intoapache:mainfrom
validio-io:bq-hash-comment

Conversation

@iffyio
Copy link
Copy Markdown
Contributor

@iffyio iffyio commented Mar 24, 2024

Adds support for single line comments using # syntax. GenericDialect isn't included because the syntax conflicts with Postgres' JSON access syntax #>

https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#single_line_comments

Adds support for single line comments using `#` syntax.
GenericDialect isn't included because the syntax conflicts
with Postgres' JSON access syntax `#>`

https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#single_line_comments
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 8407819154

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 87.884%

Totals Coverage Status
Change from base Build 8266982631: 0.01%
Covered Lines: 20491
Relevant Lines: 23316

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iffyio -- 🙏

@alamb alamb merged commit 732e1ec into apache:main Apr 7, 2024
JichaoS pushed a commit to luabase/sqlparser-rs that referenced this pull request May 7, 2024
@iffyio iffyio deleted the bq-hash-comment branch July 16, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants