Skip to content

Support PARALLEL ... and for ..ON NULL INPUT ... to CREATE FUNCTION`#1202

Merged
alamb merged 1 commit intoapache:mainfrom
dimfeld:create-function-options
Apr 6, 2024
Merged

Support PARALLEL ... and for ..ON NULL INPUT ... to CREATE FUNCTION`#1202
alamb merged 1 commit intoapache:mainfrom
dimfeld:create-function-options

Conversation

@dimfeld
Copy link
Copy Markdown
Contributor

@dimfeld dimfeld commented Apr 6, 2024

Adds two sets of keywords for CREATE FUNCTION, as described at https://www.postgresql.org/docs/current/sql-createfunction.html

Parallel-save

  • PARALLEL SAFE
  • PARALLEL UNSAFE
  • PARALLEL RESTRICTED

Called on null input

  • CALLED ON NULL INPUT
  • RETURNS NULL ON NULL INPUT
  • STRICT

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 8579595348

Details

  • 69 of 81 (85.19%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 87.922%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/mod.rs 21 33 63.64%
Totals Coverage Status
Change from base Build 8481586362: 0.002%
Covered Lines: 20630
Relevant Lines: 23464

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you for the contribution @dimfeld

@alamb alamb changed the title Add parallel-safe and called-on-null-input keywords for CREATE FUNCTION Support PARALLEL ... and for ..ON NULL INPUT ... to CREATE FUNCTION` Apr 6, 2024
@alamb
Copy link
Copy Markdown
Contributor

alamb commented Apr 6, 2024

Sorry for the delayed review. I am behind

@alamb alamb merged commit 2bf93a4 into apache:main Apr 6, 2024
@dimfeld dimfeld deleted the create-function-options branch April 6, 2024 23:44
JichaoS pushed a commit to luabase/sqlparser-rs that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants