Preserve double colon casts (and simplify cast representations)#1221
Merged
alamb merged 1 commit intoapache:mainfrom Apr 21, 2024
Merged
Preserve double colon casts (and simplify cast representations)#1221alamb merged 1 commit intoapache:mainfrom
alamb merged 1 commit intoapache:mainfrom
Conversation
Pull Request Test Coverage Report for Build 8680999989Details
💛 - Coveralls |
Contributor
|
LGTM! cc @alamb |
alamb
approved these changes
Apr 21, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's been a slight annoyance to me that
::casts are converted toCAST()-style casts when rewriting SQL using this crate, so this PR makes it so we preserve the cast syntax used in the AST. We also had three AST nodes forCAST,TRY_CAST, andSAFE_CASTwhich didn't seem necessary, so I reduced this to justExpr::Castwith akindfield that determines the particular syntax / mode of cast used.This change seems to be well covered by existing tests, but let me know if you have any suggestions for additional tests I could add here.