fix: have wildcard replace work in duckdb and snowflake syntax#1226
Merged
alamb merged 1 commit intoapache:mainfrom Apr 21, 2024
Merged
fix: have wildcard replace work in duckdb and snowflake syntax#1226alamb merged 1 commit intoapache:mainfrom
alamb merged 1 commit intoapache:mainfrom
Conversation
iffyio
reviewed
Apr 20, 2024
HiranmayaGundu
force-pushed
the
hiran/fix-replace-wildcard-3
branch
from
f90a446 to
25cfd1f
Compare
iffyio
approved these changes
Apr 21, 2024
alamb
approved these changes
Apr 21, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @HiranmayaGundu and @iffyio -- looks great!
Pull Request Test Coverage Report for Build 8768402595Details
💛 - Coveralls |
JichaoS
pushed a commit
to luabase/sqlparser-rs
that referenced
this pull request
May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snowflake and DuckDB also support
SELECT * REPLACE() from table, so enabling the functionality for both dialects.I added test cases so that the examples given in the respective documentation passed:
duck db: https://duckdb.org/docs/sql/query_syntax/select.html
snowflake: https://docs.snowflake.com/en/sql-reference/sql/select