feat: implement select * ilike for snowflake#1228
Merged
alamb merged 1 commit intoapache:mainfrom Apr 21, 2024
Merged
Conversation
HiranmayaGundu
changed the title
HiranmayaGundu
force-pushed
the
select_ilike_wildcard
branch
from
2214f5f to
f480fda
Compare
iffyio
approved these changes
Apr 20, 2024
HiranmayaGundu
force-pushed
the
select_ilike_wildcard
branch
from
f480fda to
29882fe
Compare
alamb
approved these changes
Apr 21, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @HiranmayaGundu and @iffyio for the review 🙏
|
|
||
| #[test] | ||
| fn test_select_wildcard_with_ilike_replace() { | ||
| let res = snowflake().parse_sql_statements(r#"SELECT * ILIKE '%id%' EXCLUDE col FROM tbl"#); |
Contributor
There was a problem hiding this comment.
💯 for the negative test case
Pull Request Test Coverage Report for Build 8768330043Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
SELECT * ILIKEfor Snowflake. This is the relevant SQL documentation: https://docs.snowflake.com/en/sql-reference/sql/select