Skip to content

fix redundant brackets in Hive/Snowflake/Redshift#1229

Merged
alamb merged 5 commits intoapache:mainfrom
illumex-ai:shkolar/parentheses
Apr 24, 2024
Merged

fix redundant brackets in Hive/Snowflake/Redshift#1229
alamb merged 5 commits intoapache:mainfrom
illumex-ai:shkolar/parentheses

Conversation

@yuval-illumex
Copy link
Copy Markdown
Contributor

@yuval-illumex yuval-illumex commented Apr 21, 2024

Resolve #892

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 21, 2024

Pull Request Test Coverage Report for Build 8812377951

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 89.22%

Files with Coverage Reduction New Missed Lines %
src/parser/mod.rs 1 92.68%
Totals Coverage Status
Change from base Build 8807696015: -0.001%
Covered Lines: 23190
Relevant Lines: 25992

💛 - Coveralls

Comment thread tests/sqlparser_common.rs
Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thanks @yuval-illumex and @universalmind303

@alamb alamb changed the title fix redundant brackets fix redundant brackets in Hive/Snowflake/Redshift Apr 23, 2024
@alamb
Copy link
Copy Markdown
Contributor

alamb commented Apr 23, 2024

Github claims this PR has conflicts that need to be resolved before merging. Can you please do so (otherwise I'll work on it when I next have a sqlparser ide open)

@yuval-illumex
Copy link
Copy Markdown
Contributor Author

@alamb fixed, thanks!

@alamb alamb merged commit 547c5cd into apache:main Apr 24, 2024
@alamb
Copy link
Copy Markdown
Contributor

alamb commented Apr 24, 2024

Thanks again @yuval-illumex

JichaoS pushed a commit to luabase/sqlparser-rs that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parser fails when query contains redundant brackets

4 participants