fix: Add support for MAX for NVARCHAR#1232
Merged
alamb merged 1 commit intoapache:mainfrom Apr 26, 2024
Merged
Conversation
`NVARCHAR` works similar to `VARCHAR` except it uses unicode for the character set. This means that it supports the `MAX` keyword for some dialects just like `VARCHAR`. This will change the wrapped type for `Nvarchar` to a `CharacterLength` instead of `u64`.
iffyio
approved these changes
Apr 26, 2024
alamb
approved these changes
Apr 26, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @bombsimon and @iffyio
Pull Request Test Coverage Report for Build 8812819014Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NVARCHARworks similar toVARCHARexcept it uses unicode for the character set. This means that it supports theMAXkeyword for some dialects just likeVARCHAR.This will change the wrapped type for
Nvarcharto aCharacterLengthinstead ofu64.The support for this was already mentioned in a comment in the code but wasn't supported so I was hoping this would be a reasonable change.
https://github.com/sqlparser-rs/sqlparser-rs/blob/ce85084debefd69d2d43a1bdde73e25f2cb0c9d6/src/ast/data_type.rs#L537-L538