Skip to content

Support array indexing for duckdb#1265

Merged
alamb merged 3 commits intoapache:mainfrom
luabase:arrayindex
May 9, 2024
Merged

Support array indexing for duckdb#1265
alamb merged 3 commits intoapache:mainfrom
luabase:arrayindex

Conversation

@JichaoS
Copy link
Copy Markdown
Contributor

@JichaoS JichaoS commented May 7, 2024

@coveralls
Copy link
Copy Markdown

coveralls commented May 7, 2024

Pull Request Test Coverage Report for Build 8993828008

Details

  • 16 of 17 (94.12%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 89.215%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_duckdb.rs 15 16 93.75%
Totals Coverage Status
Change from base Build 8989250736: 0.003%
Covered Lines: 24443
Relevant Lines: 27398

💛 - Coveralls

Comment thread tests/sqlparser_duckdb.rs Outdated
Copy link
Copy Markdown
Contributor

@jmhain jmhain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks! cc @alamb

Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JichaoS and @jmhain

@alamb alamb merged commit e3692f4 into apache:main May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants