Skip to content

Support for Snowflake ASOF joins #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2024
Merged

Support for Snowflake ASOF joins #1288

merged 1 commit into from
May 31, 2024

Conversation

@jmhain
Copy link
Contributor

@jmhain jmhain commented May 26, 2024

Snowflake just gained ASOF joins. This PR adds support for parsing these.

@coveralls
Copy link

coveralls commented May 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9306138083

Details

  • 47 of 52 (90.38%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 89.549%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/mod.rs 17 19 89.47%
src/ast/query.rs 4 7 57.14%
Totals Coverage Status
Change from base Build 9305920914: 0.005%
Covered Lines: 25225
Relevant Lines: 28169
💛 - Coveralls

iffyio
iffyio approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

alamb
alamb approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- thank you @jmhain

@alamb
Copy link
Contributor

alamb commented May 30, 2024

Looks like this PR has a conflict, but once that is resolved it should be good to go

@jmhain
Copy link
Contributor Author

jmhain commented May 30, 2024

@alamb Conflict resolved

@alamb alamb merged commit 80c03f5 into apache:main May 31, 2024
@alamb
Copy link
Contributor

alamb commented May 31, 2024

🚀

@jmhain jmhain deleted the asof-joins branch May 31, 2024 16:36
@max-sixty max-sixty mentioned this pull request Jun 3, 2024
Open
@Jesse-Bakker Jesse-Bakker mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

@iffyio iffyio iffyio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmhain @coveralls @alamb @iffyio