Skip to content

Add line and column number to TokenizerError, add helper function#194

Merged
nickolay merged 3 commits intoapache:masterfrom
Dandandan:tokenizer_errors
Jun 10, 2020
Merged

Add line and column number to TokenizerError, add helper function#194
nickolay merged 3 commits intoapache:masterfrom
Dandandan:tokenizer_errors

Conversation

@Dandandan
Copy link
Copy Markdown
Contributor

@Dandandan Dandandan commented Jun 9, 2020

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 9, 2020

Pull Request Test Coverage Report for Build 130065195

  • 12 of 18 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 91.667%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 0 3 0.0%
src/tokenizer.rs 12 15 80.0%
Totals Coverage Status
Change from base Build 127811132: 0.05%
Covered Lines: 4048
Relevant Lines: 4416

💛 - Coveralls

@Dandandan Dandandan changed the title Change pattern of tokenize errors to always include column and line number in error Add line and column number to TokenizerError, add helper function Jun 9, 2020
@nickolay nickolay merged commit d842f49 into apache:master Jun 10, 2020
@nickolay
Copy link
Copy Markdown
Contributor

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants