Skip to content

implement alter table for sqlite grammar#203

Merged
nickolay merged 6 commits intoapache:masterfrom
miuy56dc:add_alter_stmt
Jun 16, 2020
Merged

implement alter table for sqlite grammar#203
nickolay merged 6 commits intoapache:masterfrom
miuy56dc:add_alter_stmt

Conversation

@miuy56dc
Copy link
Copy Markdown
Contributor

implement alter table for SQLite grammar:https://www.sqlite.org/lang_altertable.html

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 16, 2020

Pull Request Test Coverage Report for Build 137608205

  • 62 of 66 (93.94%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 91.821%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 28 29 96.55%
src/ast/ddl.rs 7 10 70.0%
Files with Coverage Reduction New Missed Lines %
src/ast/ddl.rs 1 85.0%
Totals Coverage Status
Change from base Build 134288244: 0.02%
Covered Lines: 4120
Relevant Lines: 4487

💛 - Coveralls

@miuy56dc miuy56dc force-pushed the add_alter_stmt branch 6 times, most recently from 56567f8 to 31894a3 Compare June 16, 2020 12:41
@nickolay
Copy link
Copy Markdown
Contributor

Hey @mz, thanks for the PR! Please let me know when this is ready for review, as I see you're still working on it.

@miuy56dc
Copy link
Copy Markdown
Contributor Author

Hi @nickolay I'm working on the test coverage, I have already covered alter table test, but it still says that coverage decreased, can you help me to see what's wrong.

@nickolay
Copy link
Copy Markdown
Contributor

The coverage is somewhat flaky unfortunately. Given that in this case it thinks that an existing line lost coverage, whereas it wasn't covered in the first place, I think it's not worth worrying about:

AlterTableOperation::DropConstraint { name } => write!(f, "DROP CONSTRAINT {}", name),

@miuy56dc
Copy link
Copy Markdown
Contributor Author

The coverage is somewhat flaky unfortunately

Thanks, @nickolay , It's ready for review.

@mz
Copy link
Copy Markdown

mz commented Jun 16, 2020

Hey @mz, thanks for the PR! Please let me know when this is ready for review, as I see you're still working on it.

Hey, I'm @mz and he is @mashuai :-) but nice to meet you both anyway !

Comment thread src/ast/ddl.rs Outdated
Comment thread src/ast/ddl.rs Outdated
Comment thread src/ast/ddl.rs Outdated
Comment thread src/parser.rs Outdated
Comment thread src/parser.rs Outdated
@miuy56dc miuy56dc requested a review from nickolay June 16, 2020 15:31
Copy link
Copy Markdown
Contributor

@nickolay nickolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added a couple of renames and merging this now.

@nickolay nickolay merged commit faeb7d4 into apache:master Jun 16, 2020
nickolay pushed a commit that referenced this pull request Jul 31, 2020
This is a follow-up to #203
where ALTER TABLE ADD COLUMN support was initially implemented.

Fixes #233.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants