implement alter table for sqlite grammar#203
Merged
nickolay merged 6 commits intoapache:masterfrom Jun 16, 2020
Merged
Conversation
Pull Request Test Coverage Report for Build 137608205
💛 - Coveralls |
56567f8 to
31894a3
Compare
Contributor
|
Hey @mz, thanks for the PR! Please let me know when this is ready for review, as I see you're still working on it. |
Contributor
Author
|
Hi @nickolay I'm working on the test coverage, I have already covered alter table test, but it still says that coverage decreased, can you help me to see what's wrong. |
Contributor
|
The coverage is somewhat flaky unfortunately. Given that in this case it thinks that an existing line lost coverage, whereas it wasn't covered in the first place, I think it's not worth worrying about: |
Contributor
Author
Thanks, @nickolay , It's ready for review. |
nickolay
suggested changes
Jun 16, 2020
nickolay
approved these changes
Jun 16, 2020
Contributor
nickolay
left a comment
There was a problem hiding this comment.
Thanks! I added a couple of renames and merging this now.
This was referenced Jun 16, 2020
nickolay
pushed a commit
that referenced
this pull request
Jul 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implement alter table for SQLite grammar:https://www.sqlite.org/lang_altertable.html