Skip to content

Support SQLite CREATE VIRTUAL TABLE#209

Merged
nickolay merged 3 commits intoapache:masterfrom
miuy56dc:sqlite_virtual_table
Jun 28, 2020
Merged

Support SQLite CREATE VIRTUAL TABLE#209
nickolay merged 3 commits intoapache:masterfrom
miuy56dc:sqlite_virtual_table

Conversation

@miuy56dc
Copy link
Copy Markdown
Contributor

Support SQLite CREATE VIRTUAL TABLE

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 26, 2020

Pull Request Test Coverage Report for Build 150138763

  • 37 of 44 (84.09%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 91.781%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 13 15 86.67%
src/ast/mod.rs 10 15 66.67%
Files with Coverage Reduction New Missed Lines %
src/ast/mod.rs 1 80.76%
Totals Coverage Status
Change from base Build 148650756: -0.03%
Covered Lines: 4221
Relevant Lines: 4599

💛 - Coveralls

@nickolay
Copy link
Copy Markdown
Contributor

I think that we'll eventually fold the CreateVirtualTable AST variant into the generic Statement::CreateTable (and re-use the table schema parser for module_args), but I think this is good for now. Thanks!

Please note that it's preferable to use one of the verified_... methods in the test, instead of duplicating the SQL text in the tests (60f60d9)

@nickolay nickolay merged commit a53f1d2 into apache:master Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants