Snowflake: Add support for text data type modifiers#2297
Merged
iffyio merged 2 commits intoapache:mainfrom Apr 21, 2026
Merged
Conversation
iffyio
reviewed
Apr 21, 2026
| } | ||
| Keyword::TEXT => Ok(DataType::Text), | ||
| Keyword::TEXT => { | ||
| if dialect.supports_text_type_modifiers() { |
Contributor
There was a problem hiding this comment.
can we always have the parser accept the modifier if it shows up in the statement? given that its optional, I think that would match the behavior of similar datatypes
yoavcloud
force-pushed
the
sf_text_datatype_modifiers
branch
from
435b2e0 to
203f5b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.