Skip to content

Make visitor feature no_std-compatible#2343

Merged
iffyio merged 2 commits into
apache:mainfrom
LucaCappelletti94:visitor-wasm
May 21, 2026
Merged

Make visitor feature no_std-compatible#2343
iffyio merged 2 commits into
apache:mainfrom
LucaCappelletti94:visitor-wasm

Conversation

@LucaCappelletti94
Copy link
Copy Markdown
Contributor

@LucaCappelletti94 LucaCappelletti94 commented May 20, 2026

Enabling the visitor feature without std (e.g. default-features = false, features = ["visitor"] on wasm32-unknown-unknown) currently fails with ~3200 errors. The Visit / VisitMut derive in sqlparser_derive hard-codes ::std::ops::ControlFlow in the generated impls, and src/ast/visitor.rs references String / Vec / Box without importing them from alloc, so neither path resolves once the crate root evaluates #![no_std].

The existing compile-no-std CI job is extended with a --features visitor cargo check on thumbv6m-none-eabi so this regression cannot land silently again.

Copy link
Copy Markdown
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @LucaCappelletti94!

@iffyio iffyio added this pull request to the merge queue May 21, 2026
Merged via the queue into apache:main with commit e999d3d May 21, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants