Fix issue #2353: Incorrect canonicalization of NATURAL JOIN with INNE…#2355
Open
revitalkr wants to merge 1 commit into
Open
Fix issue #2353: Incorrect canonicalization of NATURAL JOIN with INNE…#2355revitalkr wants to merge 1 commit into
revitalkr wants to merge 1 commit into
Conversation
…h INNER JOIN in Snowflake dialect produces non-equivalent query
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…R JOIN in Snowflake dialect produces non-equivalent query
Closes #2353
The current canonicalization rewrites queries such as:
SELECT *
FROM t1
NATURAL JOIN t5
INNER JOIN t0 ON (t0.v1 + t5.v0) > 0
into:
t1 NATURAL JOIN (t5 INNER JOIN t0 ...)
This transformation is not semantics-preserving.
NATURAL JOIN implicitly generates join predicates based on all shared column names.
Moving t0 into the right-hand side of the NATURAL JOIN changes the set of visible columns, which may introduce additional implicit join conditions and lead to different results.
Minimal example (see issue for full repro):
SELECT *
FROM t1
NATURAL JOIN t5
INNER JOIN t0 ON (t0.v1 + t5.v0) > 0
Expected behavior:
The canonicalization should preserve semantics, e.g.:
(t1 NATURAL JOIN t5) INNER JOIN t0 ...
Fix:
Avoid right-associative parsing when NATURAL JOIN is present, ensuring that NATURAL JOIN is evaluated left-to-right.
Tests:
join_precedencetest, which previously assumed incorrect Snowflake behavior.