Skip to content

Microsoft sql server: Escape quotes in national string display#2365

Merged
iffyio merged 1 commit into
apache:mainfrom
lovasoa:fix-national-string-display
Jun 6, 2026
Merged

Microsoft sql server: Escape quotes in national string display#2365
iffyio merged 1 commit into
apache:mainfrom
lovasoa:fix-national-string-display

Conversation

@lovasoa
Copy link
Copy Markdown
Contributor

@lovasoa lovasoa commented Jun 5, 2026

Valid T-SQL (mssql dialect) such as N' '' ' would not round-trip and serialized to invalid SQL.

This bug is potentially a security vulnerability depending on how the library is used.

@lovasoa lovasoa changed the title Escape quotes in national string display Microsoft sql server: Escape quotes in national string display Jun 5, 2026
@lovasoa lovasoa marked this pull request as ready for review June 5, 2026 21:03
@lovasoa
Copy link
Copy Markdown
Contributor Author

lovasoa commented Jun 5, 2026

Hi @iffyio ! I think this needs to be prioritized, this bug is potentially exploitable.

Copy link
Copy Markdown
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @lovasoa!

@iffyio iffyio added this pull request to the merge queue Jun 6, 2026
Merged via the queue into apache:main with commit bd8a2c1 Jun 6, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants