support MySQL quote style like BEGIN#247
Merged
nickolay merged 2 commits intoapache:mainfrom Jul 30, 2020
Merged
Conversation
Pull Request Test Coverage Report for Build 187886211
💛 - Coveralls |
nickolay
suggested changes
Jul 29, 2020
Contributor
nickolay
left a comment
nickolay
left a comment
There was a problem hiding this comment.
This looks good, but I'd prefer the test for back-ticked identifiers to be in parse_identifiers or in a separate test, instead of being combined with the test for AUTO_INCREMENT.
Contributor
|
Excellent, thanks! I noticed (after merging) that https://dev.mysql.com/doc/refman/8.0/en/identifiers.html says MySQL also supports normal "double quotes" in ANSI_QUOTES mode, while with this patch the MySQL dialect doesn't seem parse those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support MySQL quote https://dev.mysql.com/doc/refman/8.0/en/keywords.html