feat: Support TABLE keyword with SELECT INTO#487
Merged
alamb merged 1 commit intoapache:mainfrom May 9, 2022
Merged
Conversation
alamb
approved these changes
May 9, 2022
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good -- thank you @MazterQyou
| pub struct SelectInto { | ||
| pub temporary: bool, | ||
| pub unlogged: bool, | ||
| pub table: bool, |
Contributor
There was a problem hiding this comment.
I like that this follows the rest of the crate's design to mirror the input syntax in the crated AST
👍
Pull Request Test Coverage Report for Build 2295027689
💛 - Coveralls |
MazterQyou
added a commit
to cube-js/sqlparser-rs
that referenced
this pull request
May 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
TABLEkeyword withSELECT INTOqueries which is valid as per PostgreSQL docs.This allows processing queries like
SELECT * INTO TEMPORARY TABLE "tmp" FROM (SELECT 1 AS COL) AS CHECKTEMPwhich otherwise would fail asTABLEwould be parsed as a table name.