Box Query in Cte
#572
Merged
Box Query in Cte
#572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2848948795
💛 - Coveralls |
alamb
reviewed
Aug 15, 2022
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
This change is fine with me, however, there is already some discussion about un Boxing the Query in Statement 🤔
cc @ever0de and @andygrove
Contributor
|
The conclusion from #556 is that |
alamb
approved these changes
Sep 27, 2022
mcheshkov
pushed a commit
to cube-js/sqlparser-rs
that referenced
this pull request
Sep 2, 2024
Can drop this after rebase on commit 0724ef1 "Box Query in Cte (apache#572)", first released in 0.24.0
mcheshkov
pushed a commit
to cube-js/sqlparser-rs
that referenced
this pull request
Sep 3, 2024
Can drop this after rebase on commit 0724ef1 "Box Query in Cte (apache#572)", first released in 0.24.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cteis the only struct that hasQueryunboxed; all other instances areBoxed. I proposeBoxingQueryinCtefor the sake of interoperability and keeping things similar, thus the PR contains the proposed change.