Skip to content

Conversation

@Jefffrey
Copy link
Contributor

Part of apache/datafusion#2469

To allow GenericDialect to parse Grouping sets.

Note that will also now parse rollup & cube as their Expr enum variant now, instead of as Expr::Function

@alamb alamb changed the title Enable grouping sets parsing for GenericDialect Support grouping sets parsing for GenericDialect Dec 28, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Jefffrey

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3775315706

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.336%

Totals Coverage Status
Change from base Build 3720056662: 0.0%
Covered Lines: 12770
Relevant Lines: 14791

💛 - Coveralls

@alamb alamb merged commit f0870fd into apache:main Dec 28, 2022
@Jefffrey Jefffrey deleted the generic_dialect_grouping_sets branch December 28, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants