Add regexp function - regexp_matches()

[jonathanc-n]

Is your feature request related to a problem or challenge?

No response

Describe the solution you'd like

regexp_match() is already implemented, so we just need to look into building on that.

Describe alternatives you've considered

No response

Additional context

Discussed in #11946

[jonathanc-n]

take

[jonathanc-n]

@jcsherin Do you think it'd be preferred to have regexp_matches on the same page as regexp_match or should i create a new file for it?

[jcsherin]

Yes, it should be possible to share code between regexp_match and regexp_matches as they are similar in functionality.

Copied from #11946 (comment)

Adding regexp_matches would be trivial - it's essentially the current regexp_match but the 'g' (global) flag is always present (whereas with the regexp_match it's disallowed)

[jonathanc-n]

@jcsherin Sorry, a little new to the arrow/datafusion ecosystem. If i want to add a regexp_matches implementation, would i have to push that to arrow, and wait for the next version to come out?

[jcsherin]

I think it is easier (less friction) to first, get something working here (with docs, test coverage) and iterate quickly over feedback from other contributors. Then it will become evident which parts are better moved upstream to arrow. So you can attempt at get this working completely here.

If you run into any roadblocks, more experienced (not me) contributors will help you out 🤝