Skip to content

Improve performance of ScalarValue::add #20933

@alamb

Description

@alamb

I bet you can make this even faster by making it mutate lhs rather than make a new one

pub(crate) fn scalar_add(lhs: &mut ScalarValue, rhs: &ScalarValue) -> Result<()> {

Originally posted by @alamb in #20768 (comment)

The other idea is to inline the implementation of precision_add to ScalarValue::add for numeric types, in order to avoid allocations when adding

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions