-
Notifications
You must be signed in to change notification settings - Fork 2k
Move Extended tests to the standard ones? #21241
Copy link
Copy link
Open
Labels
development-processRelated to development process of DataFusionRelated to development process of DataFusion
Description
Sometimes we merge something only to later find out that extended tests are failing. Now that extended tests are fast, should we just move them into the normal checks and run per commit?
The fundamental question is: do we have enough infra credits to run them on every push (like we do with the normal tests). If we do - the change is trivial, just move the checks.
^ That is on me to check.
If we don't, I think there's a smart solution - merge queues - #6880
We can have checks that only run when you're about to merge your PR. Some jobs (extended tests, mac os, etc.) would live there. The idea:
- on every push - only run fast checks that actually matter
- on merge - run everything (you don't have to wait either - GitHub will auto-merge your PR once all checks pass)
I quite like the second approach, happy to discuss if anyone has opinions.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
development-processRelated to development process of DataFusionRelated to development process of DataFusion