Skip to content

Align DataFrame::fill_null column argument with fill_nan #22806

@Nagato-Yuzuru

Description

@Nagato-Yuzuru

Follow-up from #22702

Problem

After #22702 adds fill_nan, the two sibling methods diverge:

pub fn fill_null(&self, value: ScalarValue, columns: Vec<String>) -> Result<DataFrame>
pub fn fill_nan (&self, value: ScalarValue, columns: &[&str])     -> Result<DataFrame>

fill_nan uses the ergonomic &[&str]; fill_null still uses Vec<String> (public since 2025-02). Callers write vec!["a".to_owned()] for one and &["a"] for the other.

Proposed

Converge on one convention &[&str]

Breaking change to fill_null. Needs an upgrade guide entry, and decide a breaking change or deprecate and add.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions