Skip to content

Refactor datafusion/src/physical_plan/common.rs build_file_list to take less param and reuse code #254

@jimexist

Description

@jimexist

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to the what)

So far the build_file_list fn takes a mutable Vec and requires all call sites to pass in the param. It is a better API if the recursive fn call is wrapped.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Solution is in #253

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Alternative is to leave it as is. But this way we'll have multiple code duplicates.

Additional context
Add any other context or screenshots about the feature request here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions