Skip to content

Consider to categorize Operator #3216

@jackwener

Description

@jackwener

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

categorize Operator.

----------- now ------------
Now, we put all operators in one level.
Like following:

pub enum Operator {
    /// Expressions are equal
    Eq,
    /// Expressions are not equal
    NotEq,
    /// Left side is smaller than right side
    Lt,
    /// Left side is smaller or equal to right side
    LtEq,
    /// Left side is greater than right side
    Gt,
    .....
}

Describe the solution you'd like

----------- want to do ------------

But, in fact, operator are different categories.

we can

pub enum ComparisonOp {
    Eq,
    NotEq,
    Lt,
    LtEq,
    Gt,
    GtEq,
}

pub enum Operator {
    ComparisonOp(ComparisonOp),
    other ...
}

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context

------- pg doc ---------

Like pg expr operator

9.2. Comparison Functions and Operators
....

------- project --------
In specific project

spark:

case class GreaterThan(left: Expression, right: Expression)
    extends BinaryComparison 

presto:

public class ComparisonExpression
        extends Expression
{
    private final Operator operator;
    private final Expression left;
    private final Expression right;
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions