-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Prepend sqllogictest explain result with line number #10019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepend sqllogictest explain result with line number #10019
Conversation
|
I think ci maybe happy after add feature avro. |
|
Hi @my-vegetable-has-exploded , could you help me review these small changes, conflict is most likely to happen but i know how to deal with it now ;) |
I am not sure the specifics of the problem at hand. For branch conflicts, I think it is okay to Thanks for your work. @duongcongtoai |
The current generated output matches main now, i think it is good to review |
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @duongcongtoai and @my-vegetable-has-exploded -- this looks awesome.
We may be able to make the diffs even easier to check if we can remove the ---
| // `sqllogictest` ignores whitespace differences | ||
| // | ||
| // See https://github.com/apache/arrow-datafusion/issues/6328 | ||
| let content = l.trim_start(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can remove the ---- stuff now
Maybe we could remove the --- and see if the test diff look better 🤔
Not in this PR
|
Hi @alamb look like only you can merge it :D |
|
Thanks again @duongcongtoai and @my-vegetable-has-exploded -- I merged up this PR from main and re-ran CI tests just to be sure we didn't introduce any logical conflicts and it all looks good to me. Thanks agian! |
Which issue does this PR close?
Closes #9443.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?