feat: DataFrame supports unnesting multiple columns
#10118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
jonahgao
commented
Apr 17, 2024
|
|
||
| /// Test unnesting a non-nullable list. | ||
| #[tokio::test] | ||
| async fn unnest_non_nullable_list() -> Result<()> { |
Member
Author
There was a problem hiding this comment.
Added the test suggested by @jayzhan211 in #10044 (comment)
jayzhan211
reviewed
Apr 18, 2024
| "| 3 | | | a |", | ||
| "+------+------------+------------+--------+", | ||
| ]; | ||
| assert_batches_sorted_eq!(expected, &results); |
Contributor
There was a problem hiding this comment.
I think the result is deterministic, so we can check without sorting
Then, we can have a more straightforward result
[
"+------+------------+------------+--------+",
"| list | large_list | fixed_list | string |",
"+------+------------+------------+--------+",
"| 1 | | | a |",
"| 2 | 1.1 | | a |",
"| 3 | | | a |",
"| | 2.2 | 1 | b |",
"| | 3.3 | 2 | b |",
"| | 4.4 | | b |",
"| | | 3 | c |",
"| | | 4 | c |",
"| | | | d |",
"+------+------------+------------+--------+",
]
Member
Author
There was a problem hiding this comment.
I think the result is deterministic, so we can check without sorting
Updated. Thank you @jayzhan211 . It looks much better now.
jayzhan211
reviewed
Apr 18, 2024
| "| 3 | | | a |", | ||
| "+------+------------+------------+--------+", | ||
| ]; | ||
| assert_batches_sorted_eq!(expected, &results); |
Contributor
|
Nice! Thanks @jonahgao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
#10044 has enabled SQL to support unnesting multiple columns, this PR adds the same functionality to
DataFrame.What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
Yes
Mark the
unnest_columnAPI as deprecated, and add a new API calledunnest_columns.