minor: avoid cloning the SetExpr during planning of SelectInto
#10152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgao
commented
Apr 20, 2024
| if let Some(with) = query.with { | ||
| self.plan_with_clause(with, planner_context)?; | ||
| } | ||
| let plan = self.set_expr_to_plan(*(set_expr.clone()), planner_context)?; |
Member
Author
There was a problem hiding this comment.
The removed clone is here.
comphead
approved these changes
Apr 20, 2024
Jefffrey
reviewed
Apr 21, 2024
| _ => None, | ||
| }; | ||
|
|
||
| let plan = self.set_expr_to_plan(*set_expr, planner_context)?; |
Contributor
There was a problem hiding this comment.
I've checked and the select.into field isn't used in this function, so should be good.
Though, I wonder if it might be a concern that we take the into before passing into this function, in case for some future use case it might also need the into? 🤔
Member
Author
There was a problem hiding this comment.
We can just clone the select.into if needed in the future. Currently, I think INTO is more like an independent planning unit, it is only connected with the input plan through data.
ccciudatu
pushed a commit
to hstack/datafusion
that referenced
this pull request
Apr 26, 2024
…pache#10152) * minor: avoid cloning the `SetExpr` during planning of `SelectInto` * retry ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A.
Rationale for this change
When planning
Into, we don't need to keep a copy of the wholeSetExpr, we just need to take away the necessarySelectInto.What changes are included in this PR?
Are these changes tested?
Yes. By existing tests.
Are there any user-facing changes?
No