refactor: Convert IPCWriter metrics from u64 to usize
#10278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Apr 29, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
I agree with @phillipleblanc -- nice!
Thank you for the clean up @erenavsarogullari
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9937.
What changes are included in this PR?
Currently,
IPCWritermetrics types areu64based but source values are based onusizeso this requires redundant casting onIPCWriter.write()andExternalSorter.spill(). On the other hand, another benefit ofusizeis that it guarantees to reference enough memory location by depending on the architecture such asu32oru64.Ref Discussion: #9885 (comment)
Are these changes tested?
Yes by using existing UT case such as
SortExec.test_sort_spillAre there any user-facing changes?
No