Skip to content

Conversation

@berkaysynnada
Copy link
Contributor

@berkaysynnada berkaysynnada commented Apr 29, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

AggregateExec already has

pub fn group_expr(&self) -> &PhysicalGroupBy {
     &self.group_by
 }

No need for

 pub fn group_by(&self) -> &PhysicalGroupBy {
     &self.group_by
 }

What changes are included in this PR?

AggregateExec:: group_by() is removed.

Are these changes tested?

Yes, existing tests.

Are there any user-facing changes?

A public function is removed, but it has an existing duplicate.

@berkaysynnada berkaysynnada reopened this Apr 29, 2024
@github-actions github-actions bot added the core Core DataFusion crate label Apr 29, 2024
@ozankabak ozankabak added the api change Changes the API exposed to users of the crate label Apr 29, 2024
Copy link
Contributor

@ozankabak ozankabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup. @alamb, any reason to hold on to this cruft that I may be overlooking?

@alamb
Copy link
Contributor

alamb commented Apr 29, 2024

Looks good to me -- thank you 🙏

@alamb alamb merged commit a46adee into apache:main Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api change Changes the API exposed to users of the crate core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants