chore: Add datatype info to error message #10307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crepererum
reviewed
Apr 30, 2024
| dt => { | ||
| return not_impl_err!( | ||
| "Unsupported data type in sort merge join comparator" | ||
| "{}", |
Contributor
There was a problem hiding this comment.
IIRC not_impl_err! works like format!, so you don't need to create an intermediate string here (apart from the fact that the nesting is not that readable.
Same goes for the other change.
crepererum
approved these changes
Apr 30, 2024
Member
Author
|
Thanks @crepererum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
I saw this error message
Unsupported data type in sort merge join comparatorwhen debugging some issues in Comet. It reads a bit confusing and doesn't provide useful info. It would be better at least we can add the data type info into the error message.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?