RFC: Prototype statistics extraction iterators #10715
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
May 29, 2024
| /// * `$iterator_type` is the name of the iterator type (e.g. `BoolStatsIterator`) | ||
| /// * `$parquet_statistics_type` is the type of the statistics (e.g. `ParquetStatistics::Boolean`) | ||
| /// * `$stat_value_type` is the type of the statistics value (e.g. `bool`) | ||
| macro_rules! make_stats_iterator { |
Contributor
Author
There was a problem hiding this comment.
Here is an idea to create structs like BoolStatsIterator which will return an iterator of Option<ValueStatstics<bool>> and do the validitiy / type checking
| let scalars = iterator | ||
| .map(|x| x.and_then(|s| get_statistic!(s, min, min_bytes, Some(data_type)))); | ||
| collect_scalars(data_type, scalars) | ||
| match data_type { |
Contributor
Author
There was a problem hiding this comment.
Here is an example of how they work -- you make BoolStatsIterator::new(iterator) which then returns a sequence of Option<&bool> and then the min/max can be extracted out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
re #10626
Rationale for this change
I wanted to prototype another approach that @xinlifoobar and I were discussing on #10711 and the best way to do this is via code
What changes are included in this PR?
ParquetStatisticsinto iterators ofValueStatistics<T>Are these changes tested?
Are there any user-facing changes?