Skip to content

Chore: clean up udwf example && remove redundant import #10718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2024
Merged

Chore: clean up udwf example && remove redundant import #10718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions datafusion-examples/examples/simplify_udwf_expression.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,18 +68,6 @@ impl WindowUDFImpl for SimplifySmoothItUdf {

/// this function will simplify `SimplifySmoothItUdf` to `SmoothItUdf`.
fn simplify(&self) -> Option<WindowFunctionSimplification> {
// Ok(ExprSimplifyResult::Simplified(Expr::WindowFunction(
// WindowFunction {
// fun: datafusion_expr::WindowFunctionDefinition::AggregateFunction(
// AggregateFunction::Avg,
// ),
// args,
// partition_by: partition_by.to_vec(),
// order_by: order_by.to_vec(),
// window_frame: window_frame.clone(),
// null_treatment: *null_treatment,
// },
// )))
let simplify = |window_function: datafusion_expr::expr::WindowFunction,
_: &dyn SimplifyInfo| {
Ok(Expr::WindowFunction(WindowFunction {
Expand Down
2 changes: 0 additions & 2 deletions datafusion/proto-common/src/to_proto/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,8 +289,6 @@ impl TryFrom<&ScalarValue> for protobuf::ScalarValue {
type Error = Error;

fn try_from(val: &ScalarValue) -> Result<Self, Self::Error> {
use protobuf::scalar_value::Value;

let data_type = val.data_type();
match val {
ScalarValue::Boolean(val) => {
Expand Down