Substrait support for ParquetExec round trip for simple select #10949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinlifoobar
changed the title
xinlifoobar
changed the title
xinlifoobar
commented
Jun 17, 2024
alamb
approved these changes
Jun 17, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @xinlifoobar -- this looks great to me!
| select: None, | ||
| maintain_singular_struct: false, | ||
| select: select_struct, | ||
| // FIXME: duckdb set this to true, but it's not clear why. |
Contributor
There was a problem hiding this comment.
// fixme: whatever this means
😆
alamb
approved these changes
Jun 18, 2024
| under the License. | ||
| --> | ||
|
|
||
| # Apache DataFusion Substrait Test Data |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…e#10949) * physical plan support no statistics * implement simple physical plan substrait * fix ci * fix misc * Add README.md for substrait test data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Parts of #9347. To close this ticket, at least the translations between substrait types to arrow types translations and statistics support should be added.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
Yes, but substrait for physical plans is not functional yet.