Minor: Move function::Hint to datafusion-expr crate to avoid physical-expr dependency for datafusion-function crate
#11061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
github-actions
bot
added
logical-expr
goldmedal
approved these changes
Jun 22, 2024
Contributor
goldmedal
left a comment
goldmedal
left a comment
There was a problem hiding this comment.
Thanks @jayzhan211. LGTM
alamb
changed the title
function::Hint to datafusion-expr crate to avoid physical-expr depenedeny for datafusion-function cratefunction::Hint to datafusion-expr crate to avoid physical-expr dependency for datafusion-function crate
alamb
approved these changes
Jun 22, 2024
| datafusion-common = { workspace = true } | ||
| datafusion-execution = { workspace = true } | ||
| datafusion-expr = { workspace = true } | ||
| datafusion-physical-expr = { workspace = true, default-features = true } |
| use datafusion_common::Result; | ||
| use std::sync::Arc; | ||
|
|
||
| #[derive(Debug, Clone, Copy)] |
Contributor
There was a problem hiding this comment.
Eventually it would be great to add some more comments here, but maybe as a follow on PR
Contributor
Author
|
Thanks @alamb and @goldmedal |
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jun 22, 2024
…ical-expr dependency for `datafusion-function` crate (apache#11061) * mv to expr Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * upd lock Signed-off-by: jayzhan211 <jayzhan211@gmail.com> --------- Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jun 22, 2024
…ical-expr dependency for `datafusion-function` crate (apache#11061) * mv to expr Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * upd lock Signed-off-by: jayzhan211 <jayzhan211@gmail.com> --------- Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…ical-expr dependency for `datafusion-function` crate (apache#11061) * mv to expr Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * upd lock Signed-off-by: jayzhan211 <jayzhan211@gmail.com> --------- Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
As titile
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?