Skip to content

fix flaky array query slt test #11140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix flaky array query slt test #11140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions datafusion/sqllogictest/test_files/array_query.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,11 @@ query ??I
SELECT * FROM data WHERE null = column2;
----

query ??I
query ??I rowsort
Copy link
Contributor

@comphead comphead Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering should we also fix the test below?

Copy link
Contributor Author

@leoyvens leoyvens Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one right below has a single output row, so it doesn't need to be sorted.

SELECT * FROM data WHERE column2 is distinct from null;
----
[2, 3] [2, 3] 1
[1, 2, 3] [4, 5] 1
[2, 3] [2, 3] 1

query ??I
SELECT * FROM data WHERE column2 is not distinct from null;
Expand Down