feat: Add MaxTime type for a Time that returns the max on aggregation

[jeffreyssmith2nd]

Which issue does this PR close?

Closes #11754

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

[alamb]

It seems somewhat awkward to add a "type" of metric that is logically the same bug just differs in aggregation behavior

I wonder if the same result could be achieved by writing a custom aggregation function

[jeffreyssmith2nd]

It seems somewhat awkward to add a "type" of metric that is logically the same bug just differs in aggregation behavior

I don't necessarily disagree with this, but where would the custom aggregation function live/how would it be used? There are multiple places that MetricValue::aggregate is called.

datafusion/datafusion/physical-plan/src/metrics/mod.rs

Line 246 in 02a9812

iter.for_each(|metric| accum.aggregate(metric.value()));

datafusion/datafusion/physical-plan/src/metrics/mod.rs

Line 283 in 02a9812

accum.value_mut().aggregate(metric.value());

datafusion/datafusion/physical-plan/src/metrics/mod.rs

Line 289 in 02a9812

accum.value_mut().aggregate(metric.value());

[alamb]

I had some more thoughts on this PR here: #11754

[alamb]

Marking as a draft to signify this isn't waiting on another review.

It isn't clear to me how to proceed with this PR given #11754

[jeffreyssmith2nd]

Marking as a draft to signify this isn't waiting on another review.

It isn't clear to me how to proceed with this PR given #11754

Thanks, I do intend to get back to #11754 but am not sure whether this PR will make sense to continue once I have time to think about it.

[github-actions]

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.